Fix/optimize images #1688
Merged
Fix/optimize images #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should fix "libpng error: IDAT: chunk data is too large"
"Total reduction: 500275 bytes"
|
utACK |
1 similar comment
|
utACK |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for images:
mogrify src/qt/res/*/*/*.png- should fix "libpng error: IDAT: chunk data is too large" errorfoldersinoptimize-pngs.pyscript and execute it - should result in ~500Kb reduction of total sizeIdeally, we should be running these 2 steps each time we add new image for this new image only. However, we added a bunch of images without running
mogrifyand we never usedoptimize-pngs.pyon Dash-specific images afaik, so I executed both steps on all of them to make sure we didn't miss any.